storage: move shared storage instantiation code to CCL #114267
Conversation
itsbilal
requested review from
herkolategan,
renatolabs and
jbowens
and removed request for
a team
|
This change is |
|
@williamkulju I wonder if the license requirement is rigid; looking at the code for encryption-at-rest, we instantiate it in CCL code but we don't force an enterprise license check for that. This PR does a license check too for disaggregated storage, but just wanted to confirm if that's necessary from a product standpoint. |
itsbilal
force-pushed
the
disagg-license-check
branch
from
43e0920 to
8d77f47
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
itsbilal
changed the title
itsbilal
force-pushed
the
disagg-license-check
branch
4 times, most recently
from
eeccfe3 to
6f830f6
Compare
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @jbowens, and @renatolabs)
This change moves the shared storage factory instantiation code to pkg/storageccl/engineccl/, as well as rditer.IterateReplicaKeySpansShared. This change also checks for an enterprise license before doing a fast rebalance. Fixes cockroachdb#114185. Epic: none Release note: None
itsbilal
force-pushed
the
disagg-license-check
branch
from
6f830f6 to
eebda9e
Compare
|
TFTR! bors r=RaduBerinde |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.2-114267 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/115218/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Since cockroachdb#114267, disaggregated storage rebalance requires an enterprise license to happen quickly. This change updates the disagg-rebalance roachtest to pass in a license. Epic: none Release note: None
113960: workload/schemachange: instrument PGX r=rafiss a=chrisseto #### f5df1cd workload/schemachange: instrument PGX This commit instruments the `MultiConnPool` used in the schemachange workload with OTeL by implementing `pgx.QueryTracer`. Doing so ensures that all queries executed by the workload are logged to spans. Future commits will instrument the workers and query helpers. The combination of all these instrumentations will allow debuggers to easily inspect all SQL queries emitted by the workload and isolate them to individual workers and transactions. Epic: CRDB-19168 Release note: None 115270: roachtest: require license in disagg-rebalance r=jbowens a=itsbilal Since #114267, disaggregated storage rebalance requires an enterprise license to happen quickly. This change updates the disagg-rebalance roachtest to pass in a license. Epic: none Release note: None Co-authored-by: Chris Seto <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]>
Since #114267, disaggregated storage rebalance requires an enterprise license to happen quickly. This change updates the disagg-rebalance roachtest to pass in a license. Epic: none Release note: None
This change moves the shared storage factory
instantiation code to pkg/storageccl/engineccl/, as well as
rditer.IterateReplicaKeySpansShared. This change also
checks for an enterprise license before doing a fast rebalance.
Fixes #114185.
Epic: none
Release note: None