-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: spec: move machine type, zone, local ssd defaults out of the TestSpec and the registry #114150
Merged
RaduBerinde
merged 4 commits into
cockroachdb:release-23.2
from
RaduBerinde:backport23.2-111811
Nov 10, 2023
Merged
release-23.2: spec: move machine type, zone, local ssd defaults out of the TestSpec and the registry #114150
RaduBerinde
merged 4 commits into
cockroachdb:release-23.2
from
RaduBerinde:backport23.2-111811
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: None
…onfig This is much more logical and allows the removal of the parameter from the registry. Epic: none Release note: None
Remove the default zones from `ClusterSpec` (and the registry), and add it to `RoachprodClusterConfig`. Epic: none Release note: None
We change the boolean in the TestSpec to a tri-state (default, prefer on, disable). This way we can apply the default when creating the cluster. Epic: none Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Nov 9, 2023
I somehow thought this change made it into the release-23.2 branch when it was cut, but I was wrong. |
herkolategan
approved these changes
Nov 9, 2023
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4/4 commits from #111811.
/cc @cockroachdb/release
Release justification: test-only change, keeping roachtest in updated on release branches.
This set of commits makes more progress towards #104029 and - more generally - not baking in any flag configuration into the registry itself.
spec: move RoachprodOpts args to separate struct
Epic: none
Release note: None
spec: move default machine type from ClusterSpec to RoachprodClusterConfig
This is much more logical and allows the removal of the parameter from
the registry.
Epic: none
Release note: None
spec: move default zones to RoachprodClusterConfig
Remove the default zones from
ClusterSpec
(and the registry), andadd it to
RoachprodClusterConfig
.Epic: none
Release note: None
spec: move local SSD preference to RoachprodClusterConfig
We change the boolean in the TestSpec to a tri-state (default, prefer
on, disable). This way we can apply the default when creating the
cluster.
Epic: none
Release note: None