Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: storage: disable metamorphism of excises and EFOS #114057

Merged

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Nov 8, 2023

The new excise operation and eventually file-only snapshot (EFOS) features in Pebble are experimental. Within the 23.2 release, these features must only be enabled within the context of the disaggregated storage techncial preview. These features are still experimental and unstable.

Remove the metamorphism of these settings in tests in order to stabilize the 23.2 release branch. As we approach release, we want our test failures to be high signal, and failures dependent on these settings should not block the release. On the master branch these settings will be enabled unconditionally soon, and we'll get plenty of test coverage before their general availability in 24.1.

Epic: none
Informs #112221.
Informs #113973.
Informs #114056.
Release note: none
Release justification: non-production test-only changes

@jbowens jbowens requested a review from a team as a code owner November 8, 2023 18:01
@jbowens jbowens requested a review from RaduBerinde November 8, 2023 18:01
Copy link

blathers-crl bot commented Nov 8, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 8, 2023
Copy link

blathers-crl bot commented Nov 8, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested a review from itsbilal November 8, 2023 18:02
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)

Copy link
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a safe change. I am pretty confident the bug only occurs when kv.snapshot_receiver.excise.enabled is enabled, and the EFOS setting isn't playing a role here, but until we have a root cause it might be safest to disable both to unblock the release.

The new excise operation and eventually file-only snapshot (EFOS) features in
Pebble are experimental. Within the 23.2 release, these features must only be
enabled within the context of the disaggregated storage techncial preview.
These features are still experimental and unstable.

Remove the metamorphism of these settings in tests in order to stabilize the
23.2 release branch. As we appraoch release, we want our test failures to be
high signal, and failures dependent on these settings should not block the
release. On the master branch these settings will be enabled unconditionally
soon, and we'll get plenty of test coverage before their general availability
in 24.1.

Epic: none
Informs cockroachdb#112221.
Informs cockroachdb#113973.
Informs cockroachdb#114056.
Release note: none
@jbowens jbowens force-pushed the 23.2-disable-unstable-metamorphism branch from eb09deb to c709e08 Compare November 8, 2023 18:26
@jbowens jbowens merged commit e44769a into cockroachdb:release-23.2 Nov 8, 2023
2 checks passed
@jbowens jbowens deleted the 23.2-disable-unstable-metamorphism branch November 8, 2023 20:30
@jbowens
Copy link
Collaborator Author

jbowens commented Nov 8, 2023

TFTRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants