-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: storage: disable metamorphism of excises and EFOS #114057
release-23.2: storage: disable metamorphism of excises and EFOS #114057
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a safe change. I am pretty confident the bug only occurs when kv.snapshot_receiver.excise.enabled
is enabled, and the EFOS setting isn't playing a role here, but until we have a root cause it might be safest to disable both to unblock the release.
The new excise operation and eventually file-only snapshot (EFOS) features in Pebble are experimental. Within the 23.2 release, these features must only be enabled within the context of the disaggregated storage techncial preview. These features are still experimental and unstable. Remove the metamorphism of these settings in tests in order to stabilize the 23.2 release branch. As we appraoch release, we want our test failures to be high signal, and failures dependent on these settings should not block the release. On the master branch these settings will be enabled unconditionally soon, and we'll get plenty of test coverage before their general availability in 24.1. Epic: none Informs cockroachdb#112221. Informs cockroachdb#113973. Informs cockroachdb#114056. Release note: none
eb09deb
to
c709e08
Compare
TFTRs! |
The new excise operation and eventually file-only snapshot (EFOS) features in Pebble are experimental. Within the 23.2 release, these features must only be enabled within the context of the disaggregated storage techncial preview. These features are still experimental and unstable.
Remove the metamorphism of these settings in tests in order to stabilize the 23.2 release branch. As we approach release, we want our test failures to be high signal, and failures dependent on these settings should not block the release. On the master branch these settings will be enabled unconditionally soon, and we'll get plenty of test coverage before their general availability in 24.1.
Epic: none
Informs #112221.
Informs #113973.
Informs #114056.
Release note: none
Release justification: non-production test-only changes