Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/kvnemesis: disable replicated lock validation #113887

Conversation

nvanbenschoten
Copy link
Member

Informs #111893, and others.

Deflakes kvnemesis, until #113768 is addressed.

Release note: None

Informs cockroachdb#111893, and others.

Deflakes kvnemesis, until cockroachdb#113768 is addressed.

Release note: None
@nvanbenschoten nvanbenschoten added the backport-23.2.x Flags PRs that need to be backported to 23.2. label Nov 6, 2023
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner November 6, 2023 18:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@miraradeva miraradeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 6, 2023

Build succeeded:

@craig craig bot merged commit cb8192f into cockroachdb:master Nov 6, 2023
3 checks passed
Copy link

blathers-crl bot commented Nov 6, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7219a0b to blathers/backport-release-23.2-113887: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@nvanbenschoten nvanbenschoten removed the backport-23.2.x Flags PRs that need to be backported to 23.2. label Nov 8, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/disableKVNemesisReplValidation branch November 9, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants