Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: logstore: pool MVCCStats to avoid hot path allocs #113760

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 3, 2023

Backport 1/1 commits from #113742 on behalf of @pavelkalinnikov.

/cc @cockroachdb/release


Before this commit, logstore.logAppend allocated MVCCStats on heap despite its lifetime being confined within this function's scope.

This commit switches to allocating MVCCStats on a sync.Pool. Since logAppend already has another pooled roachpb.Value with exactly the same lifetime, coalesce the allocation of both and put them in the same pool. This makes the cost of this change zero.

Microbenchmark results:

// before
BenchmarkLogStore_StoreEntries/bytes=1.0_KiB-24 837254   1270 ns/op  333 B/op  1 allocs/op
// after
BenchmarkLogStore_StoreEntries/bytes=1.0_KiB-24 1000000  1153 ns/op  157 B/op  0 allocs/op

Part of #111561
Epic: none
Release note: none


Release justification: microbenchmark regression fix

Before this commit, logstore.logAppend allocated MVCCStats on heap
despite its lifetime being confined within this function's scope.

This commit switches to allocating MVCCStats on a sync.Pool. Since
logAppend already has another pooled roachpb.Value with exactly the same
lifetime, coalesce the allocation of both and put them in the same pool.
This makes the cost of this change zero.

Microbenchmark results:

```
// before
BenchmarkLogStore_StoreEntries/bytes=1.0_KiB-24 837254   1270 ns/op  333 B/op  1 allocs/op
// after
BenchmarkLogStore_StoreEntries/bytes=1.0_KiB-24 1000000  1153 ns/op  157 B/op  0 allocs/op
```

Epic: none
Release note: none
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113742 branch from 46a7c5a to b5d4847 Compare November 3, 2023 16:15
@blathers-crl blathers-crl bot requested a review from a team November 3, 2023 16:15
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 3, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-113742 branch from 646aeb7 to 448a3ee Compare November 3, 2023 16:15
Copy link
Author

blathers-crl bot commented Nov 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from erikgrinaker and pav-kv November 3, 2023 16:15
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 3, 2023
Copy link
Author

blathers-crl bot commented Nov 3, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv merged commit 1b2091f into release-23.2 Nov 6, 2023
2 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-23.2-113742 branch November 6, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants