Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvpb: delete ErrorDetail message #113335

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Oct 31, 2023

This was unused, so delete it.

The message has been unused since 0c12f6c.

Epic: None
Release note: None

This was unused, so delete it.

Epic: None
Release note: None
@nvanbenschoten nvanbenschoten requested review from a team as code owners October 31, 2023 00:45
@blathers-crl
Copy link

blathers-crl bot commented Oct 31, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚮

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 6, 2023

Build succeeded:

@craig craig bot merged commit 4a53d0b into cockroachdb:master Nov 6, 2023
3 checks passed
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/delErrorDetail branch November 9, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants