kvserver: add metric and log when raft.Storage returns an error #113245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
erikgrinaker
approved these changes
Oct 30, 2023
pkg/kv/kvserver/metrics.go
Outdated
| @@ -1418,6 +1418,12 @@ cache will already have moved on to newer entries. | |||
| Measurement: "Bytes", | |||
| Unit: metric.Unit_BYTES, | |||
| } | |||
| metaRaftStorageError = metric.Metadata{ | |||
| Name: "raft.storage.error", | |||
| Help: "Number of calls to the raft.Storage API that returned an error", | |||
There was a problem hiding this comment.
nit: the "raft.Storage API" part seems a bit too low-level for users, consider perhaps "Number of Raft storage errors".
sumeerbhola
force-pushed
the
raft_storage_error
branch
from
0618e95 to
ffba1b6
Compare
sumeerbhola
commented
Oct 30, 2023
There was a problem hiding this comment.
TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker)
pkg/kv/kvserver/metrics.go line 1423 at r1 (raw file):
Previously, erikgrinaker (Erik Grinaker) wrote…
nit: the "raft.Storage API" part seems a bit too low-level for users, consider perhaps "Number of Raft storage errors".
Done
|
bors r=erikgrinaker |
|
Build failed: |
The raft.storage.error metric is incremented on an error, and the error is logged every 30s (across all replicas). This was motivated by a test cluster that slowed to a crawl because of deliberate data loss, but was hard to diagnose. The metric could be used for alerting, since we don't expect to see transient errors. Informs cockroachdb#113053 Epic: none Release note: None
sumeerbhola
force-pushed
the
raft_storage_error
branch
from
ffba1b6 to
063ebce
Compare
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raft.storage.error metric is incremented on an error, and the error is logged every 30s (across all replicas).
This was motivated by a test cluster that slowed to a crawl because of deliberate data loss, but was hard to diagnose. The metric could be used for alerting, since we don't expect to see transient errors.
Informs #113053
Epic: none
Release note: None