Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient: draining not started SQL #112992

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

andrewbaptist
Copy link
Collaborator

Previously a drain would assume the SQL instance had been started on a node prior to draining. This would result in a failure if the node attempting to drain had never started SQL.

Epic: none

Release note: None

Previously a drain would assume the SQL instance had been started on a
node prior to draining. This would result in a failure if the node
attempting to drain had never started SQL.

Epic: none

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist marked this pull request as ready for review October 24, 2023 20:08
@andrewbaptist andrewbaptist requested review from a team as code owners October 24, 2023 20:08
Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewbaptist
Copy link
Collaborator Author

bors r=JeffSwenson

TFTR!

@craig
Copy link
Contributor

craig bot commented Oct 25, 2023

Build succeeded:

@craig craig bot merged commit fb63e6c into cockroachdb:master Oct 25, 2023
3 checks passed
@andrewbaptist andrewbaptist deleted the 2023-10-24-drain-sql branch December 15, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants