Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: reenable Jepsen subcritical-skews test #112771

Merged
merged 1 commit into from
Oct 20, 2023
Merged

release-23.2: roachtest: reenable Jepsen subcritical-skews test #112771

merged 1 commit into from
Oct 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 20, 2023 •
edited by renatolabs
Loading

Backport 1/1 commits from #112710 on behalf of @renatolabs.

/cc @cockroachdb/release

The Jepsen version we are using already moved from ntp.ubuntu.org to pool.ntp.org. We should be able to run these tests again.

https://github.com/cockroachdb/jepsen/blob/cdeef40a0cd24af0c989e0a7990ee1c7fa948f43/cockroachdb/src/jepsen/cockroach/time.clj#L27

Fixes: #35599

Release note: None

Release justification: test-only change.

@renatolabs
roachtest: reenable Jepsen subcritical-skews test
14f34ff 
The Jepsen version we are using already moved from `ntp.ubuntu.org` to
`pool.ntp.org`. We should be able to run these tests again.

https://github.com/cockroachdb/jepsen/blob/cdeef40a0cd24af0c989e0a7990ee1c7fa948f43/cockroachdb/src/jepsen/cockroach/time.clj#L27

Fixes: #35599

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112710 branch from c011e43 to da55612 Compare October 20, 2023 17:50
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 20, 2023 17:50
@blathers-crl blathers-crl bot requested review from srosenberg and renatolabs and removed request for a team October 20, 2023 17:50
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112710 branch from e43d14d to 14f34ff Compare October 20, 2023 17:50
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 20, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs renatolabs merged commit dc24db6 into release-23.2 Oct 20, 2023
2 checks passed
@renatolabs renatolabs deleted the blathers/backport-release-23.2-112710 branch October 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herkolategan herkolategan herkolategan approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg was automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong

Assignees

@renatolabs renatolabs

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @herkolategan @renatolabs