sql: disallow invocation of procedures outside of CALL #112690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgartner
changed the title
|
This change is |
rharding6373
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
DrewKimball
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
This commit adds some missing checks to ensure that procedures cannot be invoked in any context besides as the root expression in `CALL` statements. Release note: None
This commit adds a couple of tests that show that functions can be used in procedure argument expressions. Release note: None
mgartner
force-pushed
the
proc-call-sites
branch
from
de91daf to
e67fddb
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: disallow invocation of procedures outside of CALL
This commit adds some missing checks to ensure that procedures cannot be
invoked in any context besides as the root expression in
CALLstatements.
Epic: CRDB-25388
Release note: None
sql: add tests with function invocation in procedure argument
This commit adds a couple of tests that show that functions can be used
in procedure argument expressions.
Release note: None