-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to golang v1.21.3 #112349
build: upgrade to golang v1.21.3 #112349
Conversation
2cad2f5
to
a81faf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @dhartunian, @herkolategan, @rharding6373, and @srosenberg)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @dhartunian, @herkolategan, @rickystewart, and @srosenberg)
pkg/sql/crdb_internal_test.go
line 1032 at r1 (raw file):
require.NoError(t, errUpdate) end := timeutil.Now() require.GreaterOrEqual(t, end.Sub(start), 499*time.Millisecond)
Do you know why it doesn't like 500? I don't think this is a big deal, but it's an interesting change.
I saw a failure (probably a flake) that was like: "expected current time to be 500ms + the original time, but it's only 499.6(something) ms". I don't know how this works: if it ends up eventually shelling out to a |
* [ ] Adjust the Pebble tests to run in new version. * [ ] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new version and adjust SHA256 sums as necessary. * [ ] Adjust `GO_VERSION` and `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)). * [ ] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular. * [ ] Adjust `--@io_bazel_rules_go//go/toolchain:sdk_version` in [.bazelrc](../.bazelrc). * [ ] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above. * [ ] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`). * [ ] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value. * [ ] Bump the go version in `go.mod`. * [ ] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [ ] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Epic: none Release note (general change): Updated Go version to 1.21.3
a81faf9
to
bd9d545
Compare
TFTR! bors r=rail,rharding6373 |
Build succeeded: |
Cockroach uses go1.21 as of cockroachdb/cockroach#112349. Update Pebble to do the same.
Cockroach uses go1.21 as of cockroachdb/cockroach#112349. Update Pebble to do the same.
build/teamcity/internal/release/build-and-publish-patched-go/impl.sh
with the new version and adjust SHA256 sums as necessary.GO_VERSION
andGO_FIPS_COMMIT
for the FIPS Go toolchain (source).Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac
build configuration in TeamCity with your latest version of the script above. Note the job depends on another jobBuild and Publish Patched Go
. That job prints out the SHA256 of all tarballs, which you will need to copy-paste intoWORKSPACE
(see below).Publish Patched Go for Mac
is an extra step that publishes the signedgo
binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular.--@io_bazel_rules_go//go/toolchain:sdk_version
in .bazelrc.WORKSPACE
undergo_download_sdk
. You may need to bump rules_go. Also edit the filenames listed insdks
and update all the hashes to match what you built in the step above.WORKSPACE
undergo_download_sdk
for the FIPS version of Go (go_sdk_fips
)../dev generate bazel
to refreshdistdir_files.bzl
, thenbazel fetch @distdir//:archives
to ensure you've updated all hashes to the correct value.go.mod
.bootstrap-debian.sh
(source).golang:<old_version>
andgo<old_version>
).Closes #112088.
Epic: none
Release note (general change): Updated Go version to 1.21.3