release-23.2: sql: fix statement tags for CREATE and DROP PROCEDURE

[blathers-crl]

Backport 1/1 commits from #112054 on behalf of @mgartner.

/cc @cockroachdb/release

---

Epic: CRDB-25388

Release note: None

---

Release justification: Minor bug fix for new features.

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Patches should only be created for serious issues or test-only changes.
• Patches should not break backwards-compatibility.
• Patches should change as little code as possible.
• Patches should not change on-disk formats or node communication protocols.
• Patches should not add new functionality.
• Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

• What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
• Will this work in a cluster of mixed patch versions? Did we test that?
• If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

[cockroach-teamcity]

This change is 

[rharding6373]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @ecwall, @fqazi, and @mgartner)

[michae2]

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @blathers-crl[bot], @DrewKimball, @ecwall, @fqazi, and @mgartner)

---

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/process_test.go line 24 at r1 (raw file):

func TestSupportedStatements(t *testing.T) {
	// Some statements n supportedStatements have multiple statementTags. This

typo here, but we can ignore it if it's too onerous to fix it in the backport

[michae2]

I'm not sure if it is directly related, but the timeout in TestCompareLegacyAndDeclarative is a little concerning. Maybe it's a known flake?

[DrewKimball]

Yeah, it's flaking: #112301

[mgartner]

TFTR!