Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/logictest: add CALL statements to drop_procedure #112097

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Oct 10, 2023

This commit improves the coverage of tests in drop_procedure by adding
CALL statements to ensure that dropped procedures cannot be executed.

Epic: CRDB-25388

Release note: None

This commit improves the coverage of tests in `drop_procedure` by adding
`CALL` statements to ensure that dropped procedures cannot be executed.

Release note: None
@mgartner mgartner requested review from rharding6373, DrewKimball and a team October 10, 2023 14:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)

@mgartner
Copy link
Collaborator Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 10, 2023

Build succeeded:

@craig craig bot merged commit d1981cd into cockroachdb:master Oct 10, 2023
3 checks passed
@mgartner mgartner added the backport-23.2.x Flags PRs that need to be backported to 23.2. label Oct 10, 2023
@mgartner mgartner deleted the add-call-to-drop-proc branch October 11, 2023 15:23
@mgartner
Copy link
Collaborator Author

blathers backport 23.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants