roachtest: clean up command-line flags #112078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
requested review from
herkolategan and
DarrylWong
and removed request for
a team
RaduBerinde
requested review from
srosenberg and
renatolabs
and removed request for
healthy-pod
|
This isn't urgent and I will be out next week in case there is any fallout; I will pick it back up when I come back. |
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Updated, ready for review. |
renatolabs
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Thanks for the refactor!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @herkolategan)
The code around command-line flags is pretty messy: they're defined in many places; the name and description of a flag are far away from the variable; the variable names look like local variables and in many cases it's not obvious we're accessing a global. This commit moves all flags to a separate subpackage, `roachtestflags`, making all uses of global flags obvious. We also add a bit of infrastructure to allow defining all information about a flag right next to where the variable is declared. We also provide a `Changed()` function that determines if a flag value was changed (without the caller having to use the Command or even the flag name). There should be no functional changes (just some cosmetic improvements to the flag usage texts). Epic: none Release note: None
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for the last commit. The rest are #111811
roachtest: clean up command-line flags
The code around command-line flags is pretty messy: they're defined in
many places; the name and description of a flag are far away from
the variable; the variable names look like local variables and in many
cases it's not obvious we're accessing a global.
This commit moves all flags to a separate subpackage,
roachtestflags, making all uses of global flags obvious. We also adda bit of infrastructure to allow defining all information about a flag
right next to where the variable is declared.
We also provide a
Changed()function that determines if a flag valuewas changed (without the caller having to use the Command or even the
flag name).
There should be no functional changes (just some cosmetic improvements
to the flag usage texts).
Epic: none
Release note: None