sql: allow refcursor comparison with NULL values #112070
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
DrewKimball
force-pushed
the
refcursor-comparison
branch
from
ce698e1 to
753606d
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
-- commits line 20 at r2:
Very interesting behavior! Good job getting to the bottom of it!
pkg/sql/logictest/testdata/logic_test/refcursor line 514 at r2 (raw file):
true true true
Can you add some tests for values on the RHS that lead to errors? From my testing, anything other than an untyped NULL will cause operator does not exist errors: column refs, CASE expressions, typed NULLs, etc.
Most comparisons are disallowed for the REFCURSOR data type. For example, the following is not allowed in postgres: ``` SELECT 'foo'::REFCURSOR = 'bar'::REFCURSOR; ``` However, postgres does allow using `IS [NOT] DISTINCT FROM NULL` and `IS [NOT] NULL` with a refcursor-typed expression os the left operand. There are a few places where CRDB internally expects this comparison to be valid as well, so disallowing these comparisons has caused test failures. This patch removes the refcursor-specific check for invalid comparisons during type checking, and relies on execution-time checks as is done for other comparisons. This means that `IsNull` and `IsNotNull` expressions can now be executed. In addition, the `IS DISTINCT FROM NULL` comparison is now supported only for the case of type `REFCURSOR` as the left operand, and `UNKNOWN` (NULL) as the right operand. Fixes cockroachdb#112010 Fixes cockroachdb#112011 Release note: None
DrewKimball
force-pushed
the
refcursor-comparison
branch
from
753606d to
1c2d813
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/refcursor line 514 at r2 (raw file):
typed NULLs,
Oh, good find. Done.
|
TFTRs! bors r+ |
|
Build succeeded: |
Most comparisons are disallowed for the REFCURSOR data type. For example, the following is not allowed in postgres:
However, postgres does allow using
IS [NOT] DISTINCT FROM NULLandIS [NOT] NULLwith a refcursor-typed expression os the left operand. There are a few places where CRDB internally expects this comparison to be valid as well, so disallowing these comparisons has caused test failures.This patch removes the refcursor-specific check for invalid comparisons during type checking, and relies on execution-time checks as is done for other comparisons. This means that
IsNullandIsNotNullexpressions can now be executed. In addition, theIS DISTINCT FROM NULLcomparison is now supported only for the case of typeREFCURSORas the left operand, andUNKNOWN(NULL) as the right operand.Fixes #112010
Fixes #112011
Release note: None