Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcjob_test: fix logging in TestGCJobRetry #112025

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

andyyang890
Copy link
Collaborator

This patch fixes the logging in TestGCJobRetry to handle NULL values
being returned by a query.

Fixes: #111839
Fixes: #111974
Fixes: #111990

Release note: None

@andyyang890 andyyang890 requested a review from rafiss October 9, 2023 04:47
@andyyang890 andyyang890 requested a review from a team as a code owner October 9, 2023 04:47
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Oct 9, 2023
This patch fixes the logging in `TestGCJobRetry` to handle NULL values
being returned by a query.

Release note: None
@andyyang890 andyyang890 changed the title gcjob: fix logging in TestGCJobRetry gcjob_test: fix logging in TestGCJobRetry Oct 9, 2023
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Oct 9, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
3 participants