Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: pg_catalog: indoption was not encoded correctly #111956

Merged
merged 1 commit into from
Oct 7, 2023
Merged

release-22.2: pg_catalog: indoption was not encoded correctly #111956

merged 1 commit into from
Oct 7, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 6, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #111911 on behalf of @fqazi.

/cc @cockroachdb/release

Previously, the indoption field inside pg_index was encoded incorrectly, which could cause problems for binary clients. Specifically, an int8 was being sent across the wire, then int2vectors are supposed to be made of int2. To address this, this patch ensures that an int2 is used and adds assertion inside the conversion code (for int2vector) to avoid future problems.

Fixes: #111907

Release note (bug fix): indoption inside pg_index was not properly encoded, causing clients to be unable to decode it as int2vector.

Release justification: bug fix

@fqazi
pg_catalog: indoption was not encoded correctly
f5d7606 
Previously, the indoption field inside pg_index was encoded incorrectly,
which could cause problems for binary clients. Specifically, an int8 was
being sent across the wire, then int2vectors are supposed to be made of
int2. To address this, this patch ensures that an int2 is used and adds
assertion inside the conversion code (for int2vector) to avoid future
problems.

Fixes: #111907

Release note (bug fix): indoption inside pg_index was not properly
encoded, causing clients to be unable to decode it as int2vector.
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 6, 2023 21:58
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-111911 branch from ce4950d to 966f568 Compare October 6, 2023 21:58
@blathers-crl blathers-crl bot requested review from a team as code owners October 6, 2023 21:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 6, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-111911 branch from 293b967 to f5d7606 Compare October 6, 2023 21:58
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 6, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi merged commit a622a4b into release-22.2 Oct 7, 2023
2 checks passed
@fqazi fqazi deleted the blathers/backport-release-22.2-111911 branch October 7, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@fqazi fqazi

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @fqazi