kv: dequeue request from lock table wait-queues on scan error #111923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#111352. Informs cockroachdb#111530. Informs cockroachdb#111564. Informs cockroachdb#111893. This commit demonstrates that when an initial call to the lockTable's ScanAndEnqueue method returns an error, the request was not previously being dequeued from any other wait-queues that it may have entered. Release note: None
Informs cockroachdb#111352. Informs cockroachdb#111530. Informs cockroachdb#111564. Informs cockroachdb#111893. In 8205b43, we added a case to the lock table where a request's initial scan could throw an error. This was not being handled properly if the request had already entered any other lock wait-queues. In these cases, the request's entries in those wait-queues would be abandoned and the locks would get stuck. This commit fixes that issue by dequeuing the request from the lock table when throwing an error from ScanAndEnqueue. This was one of the causes of the recent kvnemesis instability, but we believe that there is at least one other issue that is still causing timeouts. Release note: None
|
This change is |
AlexTalks
approved these changes
Oct 6, 2023
complete! 1 of 0 LGTMs obtained
|
TFTR @AlexTalks! bors r+ |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #111352.
Informs #111530.
Informs #111564.
Informs #111893.
In 8205b43, we added a case to the lock table where a request's initial scan could throw an error. This was not being handled properly if the request had already entered any other lock wait-queues. In these cases, the request's entries in those wait-queues would be abandoned and the locks would get stuck. This commit fixes that issue by dequeuing the request from the lock table when throwing an error from ScanAndEnqueue.
This was one of the causes of the recent kvnemesis instability, but we believe that there is at least one other issue that is still causing timeouts.
Release note: None