Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: storage: refactor mvcc write parameters #111870

Merged
merged 1 commit into from
Oct 6, 2023
Merged

release-23.1: storage: refactor mvcc write parameters #111870

merged 1 commit into from
Oct 6, 2023

Conversation

AlexTalks
Copy link
Contributor

Backport 1/1 commits from #107680.

/cc @cockroachdb/release

This change introduces MVCCWriteOptions, a structure for bundling parameters for MVCCPut, MVCCDelete, and their many variants, and refactors usages of these functions across the code base in order to move the existing function arguments into this structure. In addition to allowing the code to eliminate specifying default values in many callers, this enables the ability to pass new flags to write operations such as the replay protection needed to address #103817.

Part of: #103817

Release note: None

Release justification: Backporting fix for outstanding bug described in #103817.

@AlexTalks
storage: refactor mvcc write parameters
91d85f7 
This change introduces `MVCCWriteOptions`, a structure for bundling
parameters for `MVCCPut`, `MVCCDelete`, and their many variants, and
refactors usages of these functions across the code base in order to
move the existing function arguments into this structure. In addition to
allowing the code to eliminate specifying default values in many
callers, this enables the ability to pass new flags to write operations
such as the replay protection needed to address cockroachdb#103817.

Part of: cockroachdb#103817

Release note: None
@AlexTalks AlexTalks requested review from a team as code owners October 5, 2023 21:01
@AlexTalks AlexTalks requested a review from a team October 5, 2023 21:01
@AlexTalks AlexTalks requested review from a team as code owners October 5, 2023 21:01
@AlexTalks AlexTalks requested a review from bananabrick October 5, 2023 21:01
@blathers-crl
Copy link

blathers-crl bot commented Oct 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 5, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This was referenced Oct 5, 2023
Merged
Merged
@AlexTalks AlexTalks requested review from nvanbenschoten and miraradeva and removed request for a team October 5, 2023 22:20
@AlexTalks AlexTalks mentioned this pull request Oct 5, 2023
Closed
nvanbenschoten
nvanbenschoten approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 81 of 81 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bananabrick and @miraradeva)

@AlexTalks AlexTalks merged commit 580cd51 into cockroachdb:release-23.1 Oct 6, 2023
2 checks passed
@AlexTalks AlexTalks deleted the fix_backport_107680_refactor branch October 9, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

@bananabrick bananabrick Awaiting requested review from bananabrick bananabrick is a code owner automatically assigned from cockroachdb/storage

@miraradeva miraradeva Awaiting requested review from miraradeva

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexTalks @cockroach-teamcity @nvanbenschoten