Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamproducer: add verbose logging to span config event stream #111803

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Oct 5, 2023

It was helpful while looking into #111541

Epic: none

Release Note: none

It was helpful while looking into cockroachdb#111541

Release note: None
@msbutler msbutler requested a review from stevendanna October 5, 2023 00:59
@msbutler msbutler self-assigned this Oct 5, 2023
@msbutler msbutler requested a review from a team as a code owner October 5, 2023 00:59
@blathers-crl
Copy link

blathers-crl bot commented Oct 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator Author

msbutler commented Oct 5, 2023

unrelated flake

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Oct 5, 2023

Build succeeded:

@craig craig bot merged commit 767e135 into cockroachdb:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants