release-23.1: roachprod: mark dns errors #111772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously DNS errors were not marked making it hard to classify these errors later on. This change marks all DNS related errors in order to better report on the errors. Epic: None Release Note: None
|
This change is |
herkolategan
changed the title
Previously DNS errors would propagate the same way as errors that arise during a test and be triaged through the normal route. This change is to check for errors marked as DNS errors and classify it as an infra flake and assign it to the test-eng team. Epic: None Release Note: None
herkolategan
force-pushed
the
backport23.1-110831
branch
from
e567b19 to
130e325
Compare
herkolategan
requested review from
srosenberg,
renatolabs and
smg260
and removed request for
a team
smg260
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @srosenberg)
smg260
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously DNS errors were not marked making it hard to classify these errors
later on. This change marks all DNS related errors in order to better report on
the errors.
Epic: None
Release Note: NoneBackport 2/2 commits from #110831.
/cc @cockroachdb/release
Epic: None
Release Note: None
Release justification: Test only change