Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachprod: retry dns lookup on network failures #111763

Merged
merged 1 commit into from
Oct 4, 2023
Merged

release-23.1: roachprod: retry dns lookup on network failures #111763

merged 1 commit into from
Oct 4, 2023

Conversation

herkolategan
Copy link
Collaborator

@herkolategan herkolategan commented Oct 4, 2023 •
edited
Loading

Backport 1/1 commits from #110832.

/cc @cockroachdb/release

Previously we had failures in net.LookupSRV that appear to be network flakes. It would be preferable to not fail a whole roachtest on a single DNS network flake. This change wraps a retry around the dns lookup in order to prevent flakiness and have a chance of recovery.

Fixes: #110884

Release justification: Test only change
Epic: None
Release Note: None

@herkolategan
roachprod: retry dns lookup on network failures
b872307 
Previously we had failures in net.LookupSRV that appear to be network flakes. It
would be preferable to not fail a whole `roachtest` on a single DNS network flake.
This change wraps a retry around the dns lookup in order to prevent flakiness
and have a chance of recovery.

Fixes: cockroachdb#110884

Epic: None
Release Note: None
@herkolategan herkolategan requested a review from a team as a code owner October 4, 2023 15:30
@herkolategan herkolategan requested review from srosenberg and smg260 and removed request for a team October 4, 2023 15:30
@blathers-crl
Copy link

blathers-crl bot commented Oct 4, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 4, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

smg260
smg260 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@smg260 smg260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herkolategan herkolategan merged commit 35daee6 into cockroachdb:release-23.1 Oct 4, 2023
@herkolategan herkolategan deleted the backport23.1-110832 branch October 4, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smg260 smg260 smg260 approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herkolategan @cockroach-teamcity @smg260