Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-ui: pin pnpm to 8.6.10 for cluster-ui-release workflow #111656

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

THardy98
Copy link

@THardy98 THardy98 commented Oct 3, 2023

Epic: none
This change pins pnpm to 8.6.10 for the cluster-ui release (and release-next) workflow(s) to prevent not up-to-date lockfiles when installing cluster-ui dependencies with pnpm.

Release note: None

Epic: none This change pins `pnpm` to `8.6.10` for the cluster-ui
release (and release-next) workflow(s) to prevent not up-to-date
lockfiles when installing cluster-ui dependencies with pnpm.

Release note: None
@THardy98 THardy98 requested review from sjbarag and a team October 3, 2023 15:38
@THardy98 THardy98 requested a review from a team as a code owner October 3, 2023 15:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving this a try! Looks good to me, so let's see how it goes. This may need to be backported to 23.1, to support patch releases there.

@THardy98 THardy98 added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Oct 3, 2023
@THardy98
Copy link
Author

THardy98 commented Oct 3, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 3, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Oct 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-111656 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/111672/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants