Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: use SystemVisible for kv.raft.command.max_size #111642

Merged

Conversation

erikgrinaker
Copy link
Contributor

Epic: none
Release note: None

@erikgrinaker erikgrinaker requested review from knz and a team October 3, 2023 13:15
@erikgrinaker erikgrinaker requested a review from a team as a code owner October 3, 2023 13:15
@erikgrinaker erikgrinaker self-assigned this Oct 3, 2023
@blathers-crl
Copy link

blathers-crl bot commented Oct 3, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the raft-command-size-system-visible branch from 493ddc6 to c515e73 Compare October 3, 2023 16:14
@erikgrinaker erikgrinaker requested a review from a team as a code owner October 3, 2023 16:14
@erikgrinaker erikgrinaker requested review from DrewKimball and removed request for a team October 3, 2023 16:14
@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 3, 2023

Build succeeded:

@craig craig bot merged commit 00751c3 into cockroachdb:master Oct 3, 2023
3 checks passed
@erikgrinaker erikgrinaker deleted the raft-command-size-system-visible branch November 14, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants