settings: tweak the comment guidance #111579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Release note: None
knz
force-pushed
the
20231002-setting-advice
branch
from
aedf152 to
fddd6a2
Compare
|
TFYR! bors r=erikgrinaker |
dt
reviewed
Oct 2, 2023
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
111576: sql: use 'cluster-NNN' for virtual cluster records without a name r=stevendanna a=knz Epic: CRDB-29380 Prior to this patch, when a virtual cluster was created without a name, a default name was generated with structure `tenant-NNN`. To avoid emphasizing multi-tenancy, this commit changes this to `cluster-NNN`. (No release note because there is no user-facing way to create a record without a name.) Release note: None 111586: settings: more guidance r=dt a=knz Epic: CRDB-6671 As requested by `@dt` [here](#111579 (comment)). Release note: None 111587: configprofiles: more clamping down on spurious slice overwrites r=yuzefovich a=knz Epic: CRDB-26691 Suggested by `@yuzefovich` [here](#111569 (review)). Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-6671
As suggested by @erikgrinaker here and discussed here.
Release note: None