api: increase timeout to request execution details #111510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
once the lint error is fixed,
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @adityamaru)
pkg/ui/workspaces/cluster-ui/src/api/jobProfilerApi.ts line 13 at r1 (raw file):
import { cockroach } from "@cockroachlabs/crdb-protobuf-client"; import { fetchData } from "./fetchData"; import {SqlExecutionRequest, executeInternalSql, LONG_TIMEOUT} from "./sqlApi";
you're getting a lint error here:
Replace SqlExecutionRequest,·executeInternalSql,·LONG\_TIMEOUT\ with ⏎··SqlExecutionRequest,⏎··executeInternalSql,⏎··LONG\_TIMEOUT,⏎\
adityamaru
force-pushed
the
increase-job-p-timeout
branch
from
e6c5097 to
8187845
Compare
In large clusters requesting execution details can definitely take longer than 5 seconds. This is because it involves collecting cluster wide traces, goroutines and contacting the coordinator node of the job to dump its execution details. Since this is a debug only tool we bump the timeout to 300s to give it all the time it needs. Release note: None
adityamaru
force-pushed
the
increase-job-p-timeout
branch
from
8187845 to
4ec1671
Compare
|
flake is TFTR! bors r=maryliag |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large clusters requesting execution details can definitely take longer than 5 seconds. This is because it involves collecting cluster wide traces, goroutines and contacting the coordinator node of the job to dump its execution details. Since this is a debug only tool we bump the timeout to 300s to give it all the time it needs.
Epic: none
Release note: None