Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logic: Fix a few incorrect syntax in scrub logic test #111417

Merged
merged 1 commit into from
Sep 28, 2023
Merged

logic: Fix a few incorrect syntax in scrub logic test #111417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions pkg/sql/logictest/testdata/logic_test/scrub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

statement error pgcode 42P01 relation "t" does not exist
EXPERIMENTAL SCRUB TABLE t
-----

# TODO(mjibson): remove FAMILY definition after #41002 is fixed.
statement ok
Expand All @@ -24,29 +23,28 @@ INSERT INTO t VALUES (1, 'hello'), (2, 'help'), (0, 'heeee')

query TTTTTTTT
EXPERIMENTAL SCRUB TABLE t
-----
----

statement error not implemented
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS PHYSICAL

query TTTTTTTT
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS INDEX ALL
------
----

statement error not implemented
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS PHYSICAL, INDEX (name_idx)
-----

statement error specified indexes to check that do not exist on table "t": not_an_index, also_not
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS INDEX (not_an_index, also_not, name_idx)

query TTTTTTTT
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS CONSTRAINT ALL
-----
----

query TTTTTTTT
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS CONSTRAINT (abc)
-----
----

statement error pq: constraint "xyz" of relation "t" does not exist
EXPERIMENTAL SCRUB TABLE t WITH OPTIONS CONSTRAINT (xyz)
Expand All @@ -63,7 +61,7 @@ EXPERIMENTAL SCRUB TABLE v1

query TTTTTTTT
EXPERIMENTAL SCRUB DATABASE test
-----
----

# make sure there are no errors when values in the index are NULL

Expand All @@ -80,7 +78,7 @@ INSERT INTO test.xyz (x, y) VALUES (8, 2), (9, 2);

query TTTTTTBT
EXPERIMENTAL SCRUB TABLE xyz WITH OPTIONS INDEX ALL
-----
----

# Test that scrub checks work when a table has an implicit rowid primary key.

Expand Down Expand Up @@ -110,7 +108,7 @@ INSERT INTO test.fk_parent VALUES (1,1), (2,1), (3,NULL)

query TTTTTTTT
EXPERIMENTAL SCRUB TABLE test.fk_parent WITH OPTIONS CONSTRAINT (fkey)
-----
----

# Test AS OF SYSTEM TIME

Expand Down