roachtest: remove backup creation during node upgrades #111413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In upgrade tests existing nodes try to start backup schedule on every binary restart. This is not adding any value as this feature tests that cluster will run backups created at initial cluster start. At the same time those checks pollute logs constantly. This commit changes options for node restarts in upgrade tests to exclude backups. Epic: none Release note: None
aliher1911
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
|
@msbutler including you as reviewer as the person who added backup in first place so that you can ack that motivation is right. |
msbutler
approved these changes
Sep 28, 2023
|
TFTR |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upgrade tests existing nodes try to start backup schedule on every binary restart. This is not adding any value as this feature tests that cluster will run backups created at initial cluster start.
At the same time those checks pollute logs constantly. This commit changes options for node restarts in upgrade tests to exclude backups.
Epic: none
Release note: None