-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: workload/tpcc: move tpcc error checks before length checks #111296
release-22.2: workload/tpcc: move tpcc error checks before length checks #111296
Conversation
Some of the TPCC consistency checks ensure that the number of rows returned by two queries is the same. This is done by checking that if one of the iterators returns false, they both do. However, if one of the iterators encounters an error, it will return false even though there are still rows left. This could cause the consistency check to seem as if it failed with incorrect results: ``` Error: check failed: 3.3.2.4: at 1682088974198157583.0000000000: length of order.sum(o_ol_cnt) != order_line.count(*) ``` when really one of the iterators just encountered an error. This patch moves the error-checking before the length checking, so that the correct error message is returned. Fixes #102004 Release note: None
50cc26d
to
2799905
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
0900db3
to
2905629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball, @michae2, and @srosenberg)
Backport 1/1 commits from #102081 on behalf of @DrewKimball.
/cc @cockroachdb/release
Some of the TPCC consistency checks ensure that the number of rows returned by two queries is the same. This is done by checking that if one of the iterators returns false, they both do. However, if one of the iterators encounters an error, it will return false even though there are still rows left. This could cause the consistency check to seem as if it failed with incorrect results:
when really one of the iterators just encountered an error. This patch moves the error-checking before the length checking, so that the correct error message is returned.
Fixes #102004
Release note: None
Release justification: Test-only fix for a confusing user-facing error.