Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvcoord: skip TestTransactionUnexpectedlyCommitted #111205

Merged
merged 1 commit into from
Sep 25, 2023
Merged

kvcoord: skip TestTransactionUnexpectedlyCommitted #111205

merged 1 commit into from
Sep 25, 2023

Conversation

arulajmani
Copy link
Collaborator

Flaky test.

Informs #110187

Release note: None

@arulajmani arulajmani requested a review from a team as a code owner September 25, 2023 14:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani mentioned this pull request Sep 25, 2023
Merged
nvanbenschoten
nvanbenschoten approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We also see in #111090 that each of the failures in bors was caused by the test itself flaking, specifically in the TestTransactionUnexpectedlyCommitted/recovery_after_transfer_lease subtest.

When this merges, we should add the skipped-test label to #110187.

@arulajmani
Copy link
Collaborator Author

Thanks! Added the label as well.

bors r=nvanbenschoten

@arulajmani
Copy link
Collaborator Author

specifically in the TestTransactionUnexpectedlyCommitted/recovery_after_transfer_lease subtest.

Ditto for #110279.

@craig
Copy link
Contributor

craig bot commented Sep 25, 2023

Build succeeded:

@craig craig bot merged commit 529843e into cockroachdb:master Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

@AlexTalks AlexTalks Awaiting requested review from AlexTalks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arulajmani @cockroach-teamcity @nvanbenschoten