Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest: expand tag functionality to allow filtering by conjunctive… #111137

Merged
merged 3 commits into from
Sep 26, 2023
Merged

release-23.1: roachtest: expand tag functionality to allow filtering by conjunctive… #111137

merged 3 commits into from
Sep 26, 2023

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Sep 22, 2023 •
edited
Loading

Backport 4/4 commits from #99402.

/cc @cockroachdb/release

Release justification: test-only change, keep roachtest in sync

… tags.

oday, tests are matched if they have any of the specified tags. This patch introduces the ability to match tests which have all specified tags, whilst attempting to maintain backward compatibility.

Commits
1 - expand tag filtering (AND, !)
2 - convert TestSpec.Tags to map[string]struct{}
3 - suppress TeamCity log statement

Epic: none
Fixes: #96655

Release note: None

Miral Gadani added 2 commits September 22, 2023 13:04
@RaduBerinde
roachtest: expand tag functionality to allow filtering by conjunctive…
0812032 
… tags.

Today, tests are matched if they have any-of the specified tags.
This patch introduces the ability to also match tests which have "all-of"
specified tags, along with tag negation.

This example will list all tests tagged with "aws" or with both "weekly"
and "owner-test-eng" tags: "roachtest list tag:aws tag:weekly,owner-test-eng"

An example of tag negation which would list all of the tests with tag
"weekly" but not "aws": "roachtest list tag:weekly,!aws"

Epic: none
Fixes: cockroachdb#96655

Release note: None
@RaduBerinde
roachtest: add tag filters to GCE nightly roachtest to ensure "defaul…
59e0de5 
…t" and "aws" tagged tests are run

See cockroachdb#100605
@RaduBerinde RaduBerinde requested review from a team as code owners September 22, 2023 20:29
@blathers-crl
Copy link

blathers-crl bot commented Sep 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 22, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde force-pushed the backport23.1-99402 branch 2 times, most recently from 726e1e8 to 68d3002 Compare September 22, 2023 21:09
@RaduBerinde RaduBerinde mentioned this pull request Sep 25, 2023
Merged
srosenberg
srosenberg approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lots of changes, but they are small; it would help to have another pair of eyes.

smg260
smg260 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@smg260 smg260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@RaduBerinde
Copy link
Member Author

TFTRs!

@RaduBerinde RaduBerinde merged commit ad94a74 into cockroachdb:release-23.1 Sep 26, 2023
@RaduBerinde RaduBerinde deleted the backport23.1-99402 branch September 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smg260 smg260 smg260 approved these changes

@srosenberg srosenberg srosenberg approved these changes

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaduBerinde @cockroach-teamcity @srosenberg @smg260