roachprod: fix symlink detection #111136
Merged
roachprod: fix symlink detection #111136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, roachprod `put` would complain about symlinks if `EvalSymlinks(src) != src`. However, that is not always a reliable way to determine if a file is a symbolic link. The documentation for `EvalSymlinks` states: > If path is relative the result will be relative to the current > directory. Therefore, the condition mentioned above is not accurate. In particular, if one ran the command `roachprod put ./cockroach`, the symlink warning would always be displayed: `EvalSymlinks` would return `cockroach` (`./` prefix removed) and the paths would differ. This commit updates that logic to check for absolute paths instead. If the absolute paths differ, we get the symlink warning, and the warning message now also includes the path to the file that the symlink resolves to. Epic: none Release note: None
renatolabs
requested review from
rachitgsrivastava and
smg260
and removed request for
a team
|
This change is |
|
Minor fix as I kept getting that red colored warning even though I had no symlinks 🙂 |
srosenberg
requested review from
srosenberg
and removed request for
rachitgsrivastava
srosenberg
approved these changes
Sep 26, 2023
renatolabs
added
the
backport-23.1.x
|
TFTR! bors r=srosenberg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, roachprod
putwould complain about symlinks ifEvalSymlinks(src) != src. However, that is not always a reliable way to determine if a file is a symbolic link. The documentation forEvalSymlinksstates:Therefore, the condition mentioned above is not accurate. In particular, if one ran the command
roachprod put ./cockroach, the symlink warning would always be displayed:EvalSymlinkswould returncockroach(./prefix removed) and the paths would differ.This commit updates that logic to check for absolute paths instead. If the absolute paths differ, we get the symlink warning, and the warning message now also includes the path to the file that the symlink resolves to.
Epic: none
Release note: None