release-23.1: server: replace admin checks with VIEWCLUSTERMETADATA and REPAIRCLUSTERMETADATA #111131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
requested review from
rhu713
and removed request for
a team and
rhu713
|
This change is |
yuzefovich
force-pushed
the
backport23.1-110609
branch
from
29666a6 to
d08d454
Compare
rafiss
changed the title
…ERMETADATA Release note (security update): Endpoints in the admin and status server that previously required the admin role now can be used by users with the VIEWCLUSTERMETADATA or REPAIRCLUSTERMETADATA system privilege, depending on whether the endpoint is read-only or can modify state.
This commit covers a few cases that were missed by an earlier commit: cockroachdb#110084. No release note is included since it would be redundant with the release note from that PR. Release note: None
yuzefovich
force-pushed
the
backport23.1-110609
branch
from
d08d454 to
548cd02
Compare
|
Ok, the CI is green. The merge conflicts were minor, RFAL @dhartunian. We'd like to get this in by the EOW for in-site IIUC. |
dhartunian
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 1 of 10 files at r3, 9 of 9 files at r5, 8 of 8 files at r6, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
|
TFTR! |
|
thank you for taking this over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #110609.
/cc @cockroachdb/release
Release note (security update): Endpoints in the admin and status server
that previously required the admin role now can be used by users with
the VIEWCLUSTERMETADATA or REPAIRCLUSTERMETADATA system privilege,
depending on whether the endpoint is read-only or can modify state.
fixes #79571
fixes #109814
Release note: None
Release justification: needed for in-situ.