Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: unskip TestMergeQueueWithSlowNonVoterSnaps #111009

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 20, 2023

Backport 1/1 commits from #110858 on behalf of @miraradeva.

/cc @cockroachdb/release


The issue causing TestMergeQueueWithSlowNonVoterSnaps to flake was fixed in #106793.

Part of: #85372
Release note: None


Release justification:

The issue causing TestMergeQueueWithSlowNonVoterSnaps to flake was fixed
in #106793.

Part of: #85372
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 20, 2023 22:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110858 branch from ef0a46c to 789cbf0 Compare September 20, 2023 22:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110858 branch from 6e0217c to 9036a19 Compare September 20, 2023 22:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 20, 2023
@blathers-crl blathers-crl bot requested a review from arulajmani September 20, 2023 22:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miraradeva
Copy link
Contributor

Unskipping caused the test to flake similarly to 22.2, which was expected but I couldn't get it to flake on a gce worker. Will deflake in a separate PR.

@miraradeva miraradeva closed this Sep 20, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-110858 branch January 31, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants