kv rest api: add remaining range tests #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cockroachdb/developers |
| // Query remaining range. | ||
| start, end = 0, 99 |
There was a problem hiding this comment.
could add another limit here (say 75) which shouldn't interfere with the operation.
|
LGTM |
| t.Errorf("unable to decode JSON into proto.ScanResponse: %v", err) | ||
| } | ||
| numRows := end - limit | ||
| if len(scan.Rows) != numRows { |
There was a problem hiding this comment.
Another way to verify would be to construct expected results. You might do that via a Scan of the underlying rows directly from the server's db. That way you could set up a list of tests which scan with different start, end and limit keys and then compare the results using !reflect.DeepEqual(results, expResults).
Not necessary to do this--I think these tests are fine. But something to keep in mind.
|
LGTM |
andybons
force-pushed
the
andybons/kvresttests
branch
3 times, most recently
from
5c8cddc to
069fa16
Compare
andybons
force-pushed
the
andybons/kvresttests
branch
from
069fa16 to
079034c
Compare
andybons
added a commit
that referenced
this pull request
Oct 10, 2014
kv rest api: add remaining range tests
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
…ive_contains_route Case sensitive contained in logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.