settings: retire changefeed lagging ranges settings #110980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
These settings were added to 23.1 and 22.2 in patch versions via cockroachdb#110963 and cockroachdb#110970. These settings will not exists in 23.2 onwards, so this commit adds them to the retired settings list for 23.2. Release note: None Epic: None
jayshrivastava
force-pushed
the
lagging-ranges-retire-setting
branch
from
1b04484 to
1472bec
Compare
miretskiy
approved these changes
Sep 27, 2023
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings were added to 23.1 and 22.2 in patch versions via #110963 and #110970. These settings will not exists in 23.2 onwards, so this commit adds them to the retired settings list for 23.2.
Release note: None
Epic: None