ui: add error message for failed executions #110849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
force-pushed
the
insights-errs-ui
branch
from
4174a42 to
b455688
Compare
xinhaoz
requested review from
a team and
dhartunian
and removed request for
a team and
dhartunian
xinhaoz
force-pushed
the
insights-errs-ui
branch
from
b455688 to
8dfb2b1
Compare
maryliag
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Last commit only:
Reviewed 5 of 5 files at r1, 13 of 13 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
xinhaoz
force-pushed
the
insights-errs-ui
branch
4 times, most recently
from
08f0482 to
b9ee4cd
Compare
Part of cockroachdb#87785 This commit adds the error message for failed executions to the statement and transaction insights pages. Since this value can contain sensitive information, it must conform to the VIEWACTIVITY and VIEWACTIVITYREDACTED system privielges. Release note (ui change): adds "Error message" row to the statement and transaction insights details pages. If the user has VIEWACTIVITY, they are able to view the full error message. If they have VIEWACTIVTYREDACTED, they are given a redacted error message. If they have both, VIEWACTIVITYTREDACTED takes precedence.
xinhaoz
force-pushed
the
insights-errs-ui
branch
from
b9ee4cd to
8cc84b4
Compare
|
CI passed already, just pushed a rebase 👍 |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #87785
This commit adds the error message for failed executions to the
statement and transaction insights pages. Since this value can contain
sensitive information, it must conform to the VIEWACTIVITY and
VIEWACTIVITYREDACTED system privielges.
Release note (ui change): adds "Error message" row to the statement and
transaction insights details pages. If the user has VIEWACTIVITY, they
are able to view the full error message. If they have
VIEWACTIVTYREDACTED, they are given a redacted error message. If they
have both, VIEWACTIVITYTREDACTED takes precedence.
Only the most recent commit (ui) should be reviewed.