Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update metrics charts UX to show legend #110809

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

maryliag
Copy link
Contributor

Update Metrics charts UX to always show the legend. The option to show as a tooltip is still available. Now single lines can also be selected when clicking on its name on the legend.

Epic: none

https://www.loom.com/share/e5ca4c678e514f0baad5f3a4c3bcfce4

Before (as tooltip)
Screenshot 2023-09-18 at 10 17 55 AM

After (always showing)
Screenshot 2023-09-18 at 10 16 39 AM

After (single selection)
Screenshot 2023-09-18 at 10 17 05 AM

Release note (ui change): Always show the legend on Metrics charts, allowing single lines to be selected.

Update Metrics charts UX to always show the legend. The
option to show as a tooltip is still available. Now
single lines can also be selected when clicking on its name
on the legend.

Epic: none

Release note (ui change): Always show the legend on Metrics charts,
allowing single lines to be selected.
@maryliag maryliag requested review from dongniwang, kevin-v-ngo and a team September 18, 2023 13:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

@dongniwang dongniwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @kevin-v-ngo)

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 20, 2023

Build succeeded:

@craig craig bot merged commit bcac3fe into cockroachdb:master Sep 20, 2023
@maryliag maryliag deleted the chart-metrics branch September 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants