pgcryptocipherccl: convert invariant errors into assertions #110774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andyyang890
force-pushed
the
pgcrypto_cipher_assertions
branch
2 times, most recently
from
76c292c to
a46ce56
Compare
rafiss
approved these changes
Sep 18, 2023
andyyang890
commented
Sep 18, 2023
There was a problem hiding this comment.
just to check - none of these errors can occur from strange user input, right?
Yup! The assertions in cipher.go should only be hit if we forgot a enum case in the switch statement and the assertion in pkcsPad would only happen if we passed in an invalid block size (not directly configurable by user). Neither of these is currently happening.
This patch changes the checks for programmer error in the `pgcryptocipherccl` package to use `errors.AssertionFailedf` so that they are surfaced with greater visibility. Release note: None
Release note: None
andyyang890
force-pushed
the
pgcrypto_cipher_assertions
branch
from
a46ce56 to
0e38f38
Compare
|
tftr! bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the checks for programmer error in the
pgcryptociphercclpackage to useerrors.AssertionFailedfso that they are surfaced with greater visibility.Epic: None
Release note: None