Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest: default logging to file instead of stderr #110749

Merged
merged 1 commit into from
Sep 18, 2023
Merged

release-23.1: roachtest: default logging to file instead of stderr #110749

merged 1 commit into from
Sep 18, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 15, 2023 •
edited by smg260
Loading

Backport 1/1 commits from #110523 on behalf of @smg260.

/cc @cockroachdb/release

Previously, stderr/out would be cluttered by unuseful log statements from various components like testutils and sarama, which are configured to utilise the pkg/util/log. This is, by default, set to use a stderr sink. It makes parsing the TC roachtest build log especially cumbersome..

This PR introduces a roachtest specific configuration which filters all but FATAL events to stderr, and preserves what was previously being written, by including a file sink that writes to artifactsDir.

Epic: none
Release note: None

Release justification: test-only change

roachtest: default logging to file instead of stderr
9e0d30c 
Previously, stderr/out would be cluttered by unuseful log statements
from various components like `testutils` and `sarama`, which are
configured to utilise the pkg/util/log. This is, by default, set to
use a stderr sink. It makes parsing the TC roachtest build log
especially cumbersome..

This PR introduces a roachtest specific configuration which filters all
but FATAL events to stderr, and preserves what was previously being
written, by including a file sink that writes to `artifactsDir`.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 15, 2023 20:53
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110523 branch from f850994 to a0d5126 Compare September 15, 2023 20:53
@blathers-crl blathers-crl bot requested review from rachitgsrivastava and DarrylWong and removed request for a team September 15, 2023 20:53
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 15, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110523 branch from 59a5bcc to 9e0d30c Compare September 15, 2023 20:53
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 15, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@smg260 smg260 removed the request for review from rachitgsrivastava September 15, 2023 20:54
@smg260 smg260 merged commit b14296e into release-23.1 Sep 18, 2023
@smg260 smg260 deleted the blathers/backport-release-23.1-110523 branch September 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herkolategan herkolategan herkolategan approved these changes

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@smg260 smg260

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @herkolategan @smg260