Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: update UDF references in ALTER TABLE #110720

Merged
merged 1 commit into from
Sep 18, 2023
Merged

release-23.1: sql: update UDF references in ALTER TABLE #110720

merged 1 commit into from
Sep 18, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 15, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #110130 on behalf of @chrisseto.

/cc @cockroachdb/release

Previously, ALTER TABLE ... ADD CONSTRAINT statements that referenced a UDF did not appropriately update UDFs' DependedOnBy field to reference the table/constraint that utilized it. This would surface as the validation error reported in #109414, relation X: depends-on function X has no corresponding depended-on-by back reference. This commit ensures that the back references are updated by copying a hook from CREATE TABLE.

Epic: None
Fixes: #109414
Release note (bug fix): ALTER TABLE ... ADD CONSTRAINT CHECK ... statements that utilize a UDF in the CHECK no longer cause a validation error.

Release justification: bug fix

@chrisseto
sql: update UDF references in ALTER TABLE
9dac4e4 
Previously, `ALTER TABLE ... ADD CONSTRAINT` statements  that referenced
a UDF did not appropriately update UDFs' `DependedOnBy` field to
reference the table/constraint that utilized it. This would surface as
the validation error reported in #109414, `relation X: depends-on
function X has no corresponding depended-on-by back reference`. This
commit ensures that the back references are updated by copying a hook
from `CREATE TABLE`.

Epic: None
Fixes: #109414
Release note (bug fix): `ALTER TABLE ... ADD CONSTRAINT CHECK ...`
statements that utilize a UDF in the CHECK no longer cause a validation
error.
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 15, 2023 14:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110130 branch from 560e7ae to c895d39 Compare September 15, 2023 14:44
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 15, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-110130 branch from 64cd27a to 9dac4e4 Compare September 15, 2023 14:44
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 15, 2023
@blathers-crl blathers-crl bot requested review from chrisseto and rafiss September 15, 2023 14:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit e6b4c77 into release-23.1 Sep 18, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-110130 branch September 18, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@chrisseto chrisseto Awaiting requested review from chrisseto

Assignees

@chrisseto chrisseto

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @chrisseto