release: do not bump version if already bumped #110696
Merged
+29
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
added
C-bug
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Previously, if the version was bumped manually, the automation would try to bump, write the same content to the file and fail committing changes. This PR skips version bump in case it was already bumped. Additionally, some of the commit messages were adjusted. Fixes: RE-468 Release note: None
rail
force-pushed
the
fix-version-bump
branch
from
0aa3602 to
4c74b62
Compare
celiala
approved these changes
Sep 15, 2023
| @@ -274,3 +274,13 @@ func fileExistsInGit(branch string, f string) (bool, error) { | |||
| } | |||
| return true, nil | |||
| } | |||
|
|
|||
| // fileContent uses `git cat-file -p ref:file` to get to the file contents without `git checkout`. | |||
|
bors r=celiala |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the version was bumped manually, the automation would try to bump, write the same content to the file and fail committing changes.
This PR skips version bump in case it was already bumped. Additionally, some of the commit messages were adjusted.
Fixes: RE-468
Release note: None