roachtest: add c2c/multiregion/SameRegions/kv0 roachtest #110638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
rachitgsrivastava and
DarrylWong
and removed request for
a team,
rachitgsrivastava and
DarrylWong
|
This change is |
stevendanna
approved these changes
Sep 14, 2023
| return defaultWorkloadDriver(workloadCtx, setup, c, kv) | ||
| } | ||
|
|
||
| // checkRegionalConstraints checks that the kv table is constrained to the | ||
| // expected locality. | ||
| func (kv replicateKV) checkRegionalConstraints( |
There was a problem hiding this comment.
I wonder if we'll need to retry this in the future in case it takes some time for KV to enforce the constraints. I assume that right now we are assuming the test runs long enough that it really ought to be done by the time the test complete.
There was a problem hiding this comment.
hmmmm good question. For now, I'm inclined to not add retry behavior. If this specific test fails because it does not replicate the regional constraints properly after 10 minutes, I'd like to know that. I fear that adding retry behavior could hide a bug. If this test starts to flake, I'll reconsider the logic here.
This patch adds a new c2c roachtest that spins up multiregion source and destination clusters, constrains the kv database to the us-east1-b region, and asserts that the replicated span configuration enforces the regional constraint on the destination cluster during replication. Informs cockroachdb#109059 Release note: None
msbutler
force-pushed
the
butler-c2c-mr-roachtest
branch
from
5d91b69 to
c00eac5
Compare
|
TFTR!! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new c2c roachtest that spins up multiregion source and destination clusters, constrains the kv database to the us-east1-b region, and asserts that the replicated span configuration enforces the regional constraint on the destination cluster during replication.
Informs #109059
Release note: None