workload: unskip some tests against default test tenant #110598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
requested review from
rachitgsrivastava and
DarrylWong
and removed request for
a team
|
This change is |
knz
approved these changes
Sep 13, 2023
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Hm, perhaps this check is needed in acceptance tests. Let me double check that. bors r- |
|
Canceled. |
These tests were failing because we previously skipped splits if the tenant didn't have the SCATTER capability. That was recently enabled in tests, so the tests should now work. Note that this SCATTER capability check is currently needed for acceptance tests, so it's not removed entirely. Release note: None
yuzefovich
force-pushed
the
unskip-workload
branch
from
5a94e7f to
2a3c499
Compare
|
Indeed, acceptance tests currently need that check. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were failing because we previously skipped splits if the tenant didn't have the SCATTER capability. That was recently enabled in tests, so the tests should now work. Note that this SCATTER capability check is currently needed for acceptance tests, so it's not removed entirely.
Fixes: #109458.
Release note: None