pgcryptocipherccl: don't panic when passed invalid padding size #110408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
test_zero_pad
branch
2 times, most recently
from
00619f1 to
a8cbd7d
Compare
andyyang890
changed the title
rafiss
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
nice!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andyyang890 and @ecwall)
pkg/ccl/pgcryptoccl/pgcryptocipherccl/padding.go line 59 at r1 (raw file):
func zeroPadOrTruncate(data []byte, size int) ([]byte, error) { if size < 0 { return nil, errors.New("cannot zero pad or truncate to negative size")
super nit: consider errors.AssertionFailed here
This patch modifies `zeroPadOrTruncate` to return an error instead of panicking when it is passed an invalid (i.e. negative) padding size. Note that this is currently only possible as the result of programmer error. We also add a unit test to validate the function's expected behavior. Release note: None
andyyang890
force-pushed
the
test_zero_pad
branch
from
a8cbd7d to
7addf4f
Compare
andyyang890
commented
Sep 15, 2023
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/pgcryptoccl/pgcryptocipherccl/padding.go line 59 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
super nit: consider errors.AssertionFailed here
good catch, changed!
|
tftr! bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies
zeroPadOrTruncateto return an error instead of panickingwhen it is passed an invalid (i.e. negative) padding size. Note that this is
currently only possible as the result of programmer error.
We also add a unit test to validate the function's expected behavior.
Informs #21001
Release note: None