Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgcryptocipherccl: add FuzzEncryptDecryptAESNoPadding test #110380

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

andyyang890
Copy link
Collaborator

This patch adds another fuzz test for testing that a round trip of
Encrypt and Decrypt returns the original input when used with
the no padding option.

Informs #21001

Release note: None

@andyyang890 andyyang890 requested a review from a team as a code owner September 11, 2023 21:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the fuzz_no_padding branch 5 times, most recently from eac7b3d to 36d1ac2 Compare September 11, 2023 22:56
This patch adds another fuzz test for testing that a round trip of
`Encrypt` and `Decrypt` returns the original input when used with
the no padding option.

Release note: None
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do fuzz tests get run automatically on any cadence? If not, I don't think we'll be getting much value from a few manual runs :(

Copy link
Collaborator Author

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! There's currently an issue (#109680) open to add a nightly run for fuzz tests so once that is completed we should be able to get more value out of this test.

@andyyang890
Copy link
Collaborator Author

bors r=chrisseto

@craig
Copy link
Contributor

craig bot commented Sep 13, 2023

Build succeeded:

@craig craig bot merged commit defdd31 into cockroachdb:master Sep 13, 2023
@andyyang890 andyyang890 deleted the fuzz_no_padding branch September 13, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants