sql: add CREATELOGIN, CREATEDB, and CONTROLJOB system privileges #110220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): There is now a `CREATELOGIN` system privilege, which is analogous to the existing `CREATELOGIN` role option, but can also be inherited by role membership.
|
This change is |
Release note (sql change): There is now a `CREATEDB` system privilege, which is analogous to the existing `CREATEDB` role option, but can also be inherited by role membership.
This patch updates the job authorization code to only check the VIEWJOB privilege if the user does not have CONTROLJOB for ViewAccess. It also updates the comment to reflect granting access when a user has VIEWJOB and corrects a format specifier. Release note: None
andyyang890
force-pushed
the
role_option_priv
branch
from
016c8c8 to
fd83173
Compare
Release note (sql change): There is now a `CONTROLJOB` system privilege, which is analogous to the existing `CONTROLJOB` role option, but can also be inherited by role membership.
andyyang890
force-pushed
the
role_option_priv
branch
from
fd83173 to
81eb17e
Compare
andyyang890
requested review from
rhu713,
rafiss and
jayshrivastava
and removed request for
a team
rafiss
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
this is great! nice to see that the earlier refactor paid off to make these changes simpler
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava and @rhu713)
|
tftr! bors r=rafiss |
|
Build succeeded: |
This was referenced Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103237