release: released CockroachDB version 23.1.9. Next version: 23.1.10 #110197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
RaduBerinde
reviewed
Sep 7, 2023
| @@ -1,4 +1,4 @@ | |||
| # Generated file, DO NOT EDIT. Source: cloud/kubernetes/templates/bring-your-own-certs/client.yaml | |||
| # Generated file, DO NOT EDIT. Source: cockroachdb_cockroach_master/cloud/kubernetes/templates/bring-your-own-certs/client.yaml | |||
There was a problem hiding this comment.
Are these changes expected/desirable? If yes, LGTM
There was a problem hiding this comment.
We're good to merge this PR once checks pass 👍🏼 
This is expected:
- Previously this was generated from a dev's local machine/repository.
- Now this is being generated from a TC job (sandbox environment where this repository is installed in order to generate this PR)
There was a problem hiding this comment.
I think we can improve this by removing the prefix.
There was a problem hiding this comment.
👍🏼 tracking in https://cockroachlabs.atlassian.net/browse/RE-476
RaduBerinde
approved these changes
Sep 7, 2023
celiala
approved these changes
Sep 7, 2023
| @@ -1,4 +1,4 @@ | |||
| # Generated file, DO NOT EDIT. Source: cloud/kubernetes/templates/bring-your-own-certs/client.yaml | |||
| # Generated file, DO NOT EDIT. Source: cockroachdb_cockroach_master/cloud/kubernetes/templates/bring-your-own-certs/client.yaml | |||
There was a problem hiding this comment.
We're good to merge this PR once checks pass 👍🏼
This is expected:
- Previously this was generated from a dev's local machine/repository.
- Now this is being generated from a TC job (sandbox environment where this repository is installed in order to generate this PR)
|
bors r=RaduBerinde,celiala |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None
Epic: None