Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql/tests: fix test size of random syntax generation #109865

Merged
merged 1 commit into from
Sep 1, 2023
Merged

release-22.2: sql/tests: fix test size of random syntax generation #109865

merged 1 commit into from
Sep 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 1, 2023 •
edited by rafiss
Loading

Backport 1/1 commits from #109484 on behalf of @fqazi.

/cc @cockroachdb/release

fixes #95619

Previously, the test size of the RSG tests within the nightly environment was not configured correctly. While the nightly script sets a timeout, its overwritten by the value from the bazel files. As a result, the TestRandomSyntaxFunction fails in CI environments when run using the nightly scripts. To address this, this patch bumps the test size to enormous.

Fixes: #109068

Release note: None

Release justification: low risk fix linked to build environment only

Release justification: test only change

@fqazi
release-23.1: sql/tests: fix test size of random syntax generation
63c1cf1 
Previously, the test size of the RSG tests within
the nightly environment was not configured correctly.
While the nightly script sets a timeout its overwritten
by the value from the bazel files. As a result the
TestRandomSyntaxFunction fails in CI environments when
run using the nightly scripts. To address this, this
patch bumps the test size to enormous.

Fixes: #109068

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-109484 branch from 11dd555 to ddc6292 Compare September 1, 2023 05:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 1, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 1, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-109484 branch from 5f5d8e7 to 63c1cf1 Compare September 1, 2023 05:16
@blathers-crl blathers-crl bot requested a review from rafiss September 1, 2023 05:16
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 1, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss changed the title release-22.2: release-23.1: sql/tests: fix test size of random syntax generation release-22.2: sql/tests: fix test size of random syntax generation Sep 1, 2023
@rafiss rafiss merged commit 8a53cda into release-22.2 Sep 1, 2023
@rafiss rafiss deleted the blathers/backport-release-22.2-109484 branch September 1, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@fqazi fqazi

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @fqazi