Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl,roachtest: remove uses of storage.mvcc.range_tombstones.enabled #109823

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Aug 31, 2023

Remove uses of the storage.mvcc.range_tombstones.enabled cluster setting. This cluster setting is ignored in cluster version 23.1+.

Epic: none
Informs #97869.
Release note: none

Remove uses of the `storage.mvcc.range_tombstones.enabled` cluster setting.
This cluster setting is ignored in cluster version 23.1+.

Epic: none
Informs cockroachdb#97869.
Release note: none
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested review from a team and bananabrick September 1, 2023 22:02
@jbowens jbowens marked this pull request as ready for review September 1, 2023 22:03
@jbowens jbowens requested review from a team as code owners September 1, 2023 22:03
@jbowens jbowens requested review from smg260, renatolabs, adityamaru and HonoreDB and removed request for a team September 1, 2023 22:03
Copy link
Contributor

@bananabrick bananabrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @adityamaru, @HonoreDB, @renatolabs, and @smg260)

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 9, 2023

tftr!

bors r=bananabrick

@craig
Copy link
Contributor

craig bot commented Sep 9, 2023

Build succeeded:

@craig craig bot merged commit b5836a5 into cockroachdb:master Sep 9, 2023
@jbowens jbowens deleted the rtombs branch September 9, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants